Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Pause Demo - Object not rotating + 4.0 changes #701

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Fixing Pause Demo - Object not rotating + 4.0 changes #701

merged 1 commit into from
Apr 3, 2022

Conversation

voylin
Copy link
Contributor

@voylin voylin commented Mar 30, 2022

Fixes #700

@Calinou Calinou added the bug label Mar 30, 2022
@voylin voylin mentioned this pull request Mar 31, 2022
Open
89 tasks
aaronfranke
aaronfranke reviewed Apr 3, 2022
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be setting demos to Vulkan Mobile if it doesn't look any different compared to Vulkan Clustered. Especially for GUI-only demos, they will look the same in Vulkan Mobile. Go to Project -> Project Settings -> General tab -> Rendering section -> Vulkan -> Back End -> Select Forward Mobile.

misc/pause/spinpause.tscn Outdated Show resolved Hide resolved
misc/pause/spinpause.tscn Outdated Show resolved Hide resolved
aaronfranke
aaronfranke reviewed Apr 3, 2022
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The button_pressed parameter in the script (pause_button.gd lines 11-15) needs to be renamed to is_button_pressed or similar.

@aaronfranke aaronfranke added this to the 4.0 milestone Apr 3, 2022
@voylin
Fixing Pause Demo - Object not rotating + 4.0 changes
8793b71 
Fixes #700

Update misc/pause/spinpause.tscn

Co-authored-by: Aaron Franke <[email protected]>
Update misc/pause/spinpause.tscn

Co-authored-by: Aaron Franke <[email protected]>
Small fixes
@voylin
Copy link
Contributor Author

voylin commented Apr 3, 2022

@aaronfranke Thank you for the suggestion, everything is fixed now.

aaronfranke
aaronfranke approved these changes Apr 3, 2022
View reviewed changes
Copy link
Member

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aaronfranke aaronfranke merged commit be59edc into godotengine:4.0-dev Apr 3, 2022
@voylin voylin deleted the Fix_Pause_Demo_4.0-dev branch April 3, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronfranke aaronfranke aaronfranke approved these changes

Assignees
No one assigned
Labels
bug update
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@voylin @aaronfranke @Calinou